Skip to content

feat: add gpu example #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: add gpu example #843

wants to merge 7 commits into from
+326 −1

Conversation

@vburckhardt
Copy link
Member

@vburckhardt vburckhardt commented Oct 28, 2025 •
edited
Loading

Description

fixes #836

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

This pull request adds a new GPU worker pool example for deploying OpenShift clusters on IBM Cloud VPC. The example demonstrates how to create a cluster with both general-purpose and GPU-enabled nodes, and includes supporting Terraform configuration, documentation, and automated test coverage.

New GPU worker pool example:

  • Added a new documented example in examples/gpu for provisioning an OpenShift cluster with a default worker pool and a GPU worker pool, including configuration for VPC, subnets, resource group, and worker pools.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vburckhardt vburckhardt marked this pull request as ready for review October 28, 2025 11:51
@vburckhardt
Copy link
Member Author

/run pipeline

@vburckhardt
Copy link
Member Author 

Error: CreateFlowLogCollectorWithContext failed: Your Cloud Object Storage (COS)
bucket is missing the Identity Authorization Management (IAM) authorization to allow
the flow logs service to write flow logs to your bucket. (Error response code returned
from COS Config call: 403)
``` in tests.

@vburckhardt
Copy link
Member Author

/run pipeline

ocofaigh
ocofaigh reviewed Oct 29, 2025
View reviewed changes
examples/gpu/catalogValidationValues.json.template Outdated
"region": "us-south",
"resource_tags": $TAGS,
"prefix": $PREFIX
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed since we no longer onboard to module registry

@ocofaigh
Copy link
Contributor

A fix was added in #840 for the validation error so this should get past that issue on next pipeline run

@ocofaigh ocofaigh mentioned this pull request Oct 29, 2025
Open
@vburckhardt vburckhardt requested a review from ocofaigh October 31, 2025 11:37
@vburckhardt
Copy link
Member Author

/run pipeline

@vburckhardt
Copy link
Member Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

@ocofaigh ocofaigh Awaiting requested review from ocofaigh

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limit provisioning to one GPU worker node in only one zone

3 participants

@vburckhardt @ocofaigh